lkml.org 
[lkml]   [2020]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 20/30] misc: mic: scif: scif_epd: Describe missing 'scifdev' argument(s)
    Date
    For some reason (copy 'n' paste error?) the passed in pointers to
    'struct scif_dev scifdev' weren't described throughout the source
    file. Change that.

    Fixes the following W=1 kernel build warning(s):

    drivers/misc/mic/scif/scif_epd.c:120: warning: Function parameter or member 'scifdev' not described in 'scif_cnctreq'
    drivers/misc/mic/scif/scif_epd.c:166: warning: Function parameter or member 'scifdev' not described in 'scif_cnctgnt'
    drivers/misc/mic/scif/scif_epd.c:191: warning: Function parameter or member 'scifdev' not described in 'scif_cnctgnt_ack'
    drivers/misc/mic/scif/scif_epd.c:213: warning: Function parameter or member 'scifdev' not described in 'scif_cnctgnt_nack'
    drivers/misc/mic/scif/scif_epd.c:230: warning: Function parameter or member 'scifdev' not described in 'scif_cnctrej'
    drivers/misc/mic/scif/scif_epd.c:255: warning: Function parameter or member 'scifdev' not described in 'scif_discnct'
    drivers/misc/mic/scif/scif_epd.c:309: warning: Function parameter or member 'scifdev' not described in 'scif_discnt_ack'
    drivers/misc/mic/scif/scif_epd.c:325: warning: Function parameter or member 'scifdev' not described in 'scif_clientsend'
    drivers/misc/mic/scif/scif_epd.c:341: warning: Function parameter or member 'scifdev' not described in 'scif_clientrcvd'

    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/misc/mic/scif/scif_epd.c | 9 +++++++++
    1 file changed, 9 insertions(+)

    diff --git a/drivers/misc/mic/scif/scif_epd.c b/drivers/misc/mic/scif/scif_epd.c
    index 590baca9dc7bf..426687f6696b5 100644
    --- a/drivers/misc/mic/scif/scif_epd.c
    +++ b/drivers/misc/mic/scif/scif_epd.c
    @@ -104,6 +104,7 @@ void scif_cleanup_zombie_epd(void)

    /**
    * scif_cnctreq() - Respond to SCIF_CNCT_REQ interrupt message
    + * @scifdev: SCIF device
    * @msg: Interrupt message
    *
    * This message is initiated by the remote node to request a connection
    @@ -155,6 +156,7 @@ void scif_cnctreq(struct scif_dev *scifdev, struct scifmsg *msg)

    /**
    * scif_cnctgnt() - Respond to SCIF_CNCT_GNT interrupt message
    + * @scifdev: SCIF device
    * @msg: Interrupt message
    *
    * An accept() on the remote node has occurred and sent this message
    @@ -181,6 +183,7 @@ void scif_cnctgnt(struct scif_dev *scifdev, struct scifmsg *msg)

    /**
    * scif_cnctgnt_ack() - Respond to SCIF_CNCT_GNTACK interrupt message
    + * @scifdev: SCIF device
    * @msg: Interrupt message
    *
    * The remote connection request has finished mapping the local memory.
    @@ -203,6 +206,7 @@ void scif_cnctgnt_ack(struct scif_dev *scifdev, struct scifmsg *msg)

    /**
    * scif_cnctgnt_nack() - Respond to SCIF_CNCT_GNTNACK interrupt message
    + * @scifdev: SCIF device
    * @msg: Interrupt message
    *
    * The remote connection request failed to map the local memory it was sent.
    @@ -221,6 +225,7 @@ void scif_cnctgnt_nack(struct scif_dev *scifdev, struct scifmsg *msg)

    /**
    * scif_cnctrej() - Respond to SCIF_CNCT_REJ interrupt message
    + * @scifdev: SCIF device
    * @msg: Interrupt message
    *
    * The remote end has rejected the connection request. Set the end
    @@ -240,6 +245,7 @@ void scif_cnctrej(struct scif_dev *scifdev, struct scifmsg *msg)

    /**
    * scif_discnct() - Respond to SCIF_DISCNCT interrupt message
    + * @scifdev: SCIF device
    * @msg: Interrupt message
    *
    * The remote node has indicated close() has been called on its end
    @@ -301,6 +307,7 @@ void scif_discnct(struct scif_dev *scifdev, struct scifmsg *msg)

    /**
    * scif_discnct_ack() - Respond to SCIF_DISCNT_ACK interrupt message
    + * @scifdev: SCIF device
    * @msg: Interrupt message
    *
    * Remote side has indicated it has not more references to local resources
    @@ -317,6 +324,7 @@ void scif_discnt_ack(struct scif_dev *scifdev, struct scifmsg *msg)

    /**
    * scif_clientsend() - Respond to SCIF_CLIENT_SEND interrupt message
    + * @scifdev: SCIF device
    * @msg: Interrupt message
    *
    * Remote side is confirming send or receive interrupt handling is complete.
    @@ -333,6 +341,7 @@ void scif_clientsend(struct scif_dev *scifdev, struct scifmsg *msg)

    /**
    * scif_clientrcvd() - Respond to SCIF_CLIENT_RCVD interrupt message
    + * @scifdev: SCIF device
    * @msg: Interrupt message
    *
    * Remote side is confirming send or receive interrupt handling is complete.
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-30 15:53    [W:3.052 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site