Messages in this thread Patch in this message | | | From | Adrian Hunter <> | Subject | [PATCH 3/3] perf intel-pt: Fix PEBS sample for XMM registers | Date | Tue, 30 Jun 2020 16:39:35 +0300 |
| |
The condition to add XMM registers was missing, the regs array needed to be in the outer scope, and the size of the regs array was too small.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Fixes: 143d34a6b387b ("perf intel-pt: Add XMM registers to synthesized PEBS sample") --- tools/perf/util/intel-pt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/intel-pt.c b/tools/perf/util/intel-pt.c index e4dd8bf610ce..cb3c1e569a2d 100644 --- a/tools/perf/util/intel-pt.c +++ b/tools/perf/util/intel-pt.c @@ -1735,6 +1735,7 @@ static int intel_pt_synth_pebs_sample(struct intel_pt_queue *ptq) u64 sample_type = evsel->core.attr.sample_type; u64 id = evsel->core.id[0]; u8 cpumode; + u64 regs[8 * sizeof(sample.intr_regs.mask)]; if (intel_pt_skip_event(pt)) return 0; @@ -1784,8 +1785,8 @@ static int intel_pt_synth_pebs_sample(struct intel_pt_queue *ptq) } if (sample_type & PERF_SAMPLE_REGS_INTR && - items->mask[INTEL_PT_GP_REGS_POS]) { - u64 regs[sizeof(sample.intr_regs.mask)]; + (items->mask[INTEL_PT_GP_REGS_POS] || + items->mask[INTEL_PT_XMM_POS])) { u64 regs_mask = evsel->core.attr.sample_regs_intr; u64 *pos; -- 2.17.1
| |