Messages in this thread | | | Date | Tue, 30 Jun 2020 14:09:00 +0200 | From | Sebastian Andrzej Siewior <> | Subject | Re: [PATCH 2/2] x86/entry: Remove `regs' parameter from idtentry_exit_cond_resched() |
| |
On 2020-06-30 13:14:30 [+0200], Peter Zijlstra wrote: > > -static void idtentry_exit_cond_resched(struct pt_regs *regs, bool may_sched) > > +static void idtentry_exit_cond_resched(bool may_sched) > > This is a style question; so far all idtentry_*() functions have regs > passed. In the lockdep-vs-nmi series I introduce > idtentry_{enter,exit}_nmi() both having an unused regs argument. > > Not sure which way around I feel on this.
Do as you are pleased. I was more attached to the previous patch that to this one :)
Sebastian
| |