Messages in this thread | | | Date | Tue, 30 Jun 2020 13:14:30 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 2/2] x86/entry: Remove `regs' parameter from idtentry_exit_cond_resched() |
| |
On Tue, Jun 30, 2020 at 12:22:09PM +0200, Sebastian Andrzej Siewior wrote: > The `regs' parameter is not used in idtentry_exit_cond_resched() and can > be removed. > > Remove the `regs' parameter. > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > --- > arch/x86/entry/common.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/entry/common.c b/arch/x86/entry/common.c > index 212382f61b8e4..652dce37643b4 100644 > --- a/arch/x86/entry/common.c > +++ b/arch/x86/entry/common.c > @@ -610,7 +610,7 @@ bool noinstr idtentry_enter_cond_rcu(struct pt_regs *regs) > return false; > } > > -static void idtentry_exit_cond_resched(struct pt_regs *regs, bool may_sched) > +static void idtentry_exit_cond_resched(bool may_sched)
This is a style question; so far all idtentry_*() functions have regs passed. In the lockdep-vs-nmi series I introduce idtentry_{enter,exit}_nmi() both having an unused regs argument.
Not sure which way around I feel on this.
| |