| From | Bartosz Golaszewski <> | Date | Tue, 30 Jun 2020 10:56:57 +0200 | Subject | Re: [PATCH 11/22] gpiolib: cdev: remove recalculation of offset |
| |
On Tue, Jun 23, 2020 at 6:02 AM Kent Gibson <warthog618@gmail.com> wrote: > > Remove recalculation of offset from desc, where desc itself was calculated > from offset. > > There is no benefit from for the desc -> hwgpio conversion in this > context. The only implicit benefit of the offset -> desc -> hwgpio is > the range check in the offset -> desc, but where desc is required you > still get that, and where desc isn't required it is simpler to perform > the range check directly. > > Signed-off-by: Kent Gibson <warthog618@gmail.com>
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
|