Messages in this thread Patch in this message | | | Date | Mon, 29 Jun 2020 21:49:40 -0700 | Subject | [PATCH v2 4/7] PCI: Add device even if driver attach failed | From | Rajat Jain <> |
| |
device_attach() returning failure indicates a driver error while trying to probe the device. In such a scenario, the PCI device should still be added in the system and be visible to the user.
This patch partially reverts: commit ab1a187bba5c ("PCI: Check device_attach() return value always")
Signed-off-by: Rajat Jain <rajatja@google.com> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- v2: Cosmetic change in commit log. Add Greg's "reviewed-by"
drivers/pci/bus.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c index 8e40b3e6da77d..3cef835b375fd 100644 --- a/drivers/pci/bus.c +++ b/drivers/pci/bus.c @@ -322,12 +322,8 @@ void pci_bus_add_device(struct pci_dev *dev) dev->match_driver = true; retval = device_attach(&dev->dev); - if (retval < 0 && retval != -EPROBE_DEFER) { + if (retval < 0 && retval != -EPROBE_DEFER) pci_warn(dev, "device attach failed (%d)\n", retval); - pci_proc_detach_device(dev); - pci_remove_sysfs_dev_files(dev); - return; - } pci_dev_assign_added(dev, true); } -- 2.27.0.212.ge8ba1cc988-goog
| |