Messages in this thread | | | From | David Gow <> | Date | Tue, 30 Jun 2020 15:15:28 +0800 | Subject | Re: [PATCH] kunit: kunit_config: Fix parsing of CONFIG options with space |
| |
On Mon, Jun 8, 2020 at 5:57 AM Rikard Falkeborn <rikard.falkeborn@gmail.com> wrote: > > Commit 8b59cd81dc5e ("kbuild: ensure full rebuild when the compiler is > updated") introduced a new CONFIG option CONFIG_CC_VERSION_TEXT. On my > system, this is set to "gcc (GCC) 10.1.0" which breaks KUnit config > parsing which did not like the spaces in the string. > > Fix this by updating the regex to allow strings containing spaces. > > Fixes: 8b59cd81dc5e ("kbuild: ensure full rebuild when the compiler is updated") > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Tested-by: David Gow <davidgow@google.com>
I've been using this patch quite a bit, and haven't hit any problems.
+Shuah: Any chance we get this into the kunit branch sooner rather than later? The KUnit tooling is quite broken without it.
> --- > Maybe it would have been sufficient to just use > CONFIG_PATTERN = r'^CONFIG_(\w+)=(.*)$' instead? >
FWIW, I tried this myself, and it seemed to work, but I think I like requiring the quotes more.
Cheers, -- David
| |