Messages in this thread | | | Date | Tue, 30 Jun 2020 09:13:47 +0200 | From | haver <> | Subject | Re: [PATCH 2/4] misc: genwqe: Constify struct pci_error_handlers |
| |
On 2020-06-11 00:47, Rikard Falkeborn wrote: > genwqe_err_handler is never modified, so it can be made const to allow > the compiler to put it in read-only memory. > > Before: > text data bss dec hex filename > 20174 6104 2464 28742 7046 drivers/misc/genwqe/card_base.o > > After: > text data bss dec hex filename > 20270 6008 2464 28742 7046 drivers/misc/genwqe/card_base.o > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> > --- > drivers/misc/genwqe/card_base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/genwqe/card_base.c > b/drivers/misc/genwqe/card_base.c > index 1dc6c7c5cbce..9969c0003f15 100644 > --- a/drivers/misc/genwqe/card_base.c > +++ b/drivers/misc/genwqe/card_base.c > @@ -1324,7 +1324,7 @@ static int genwqe_sriov_configure(struct pci_dev > *dev, int numvfs) > return 0; > } > > -static struct pci_error_handlers genwqe_err_handler = { > +static const struct pci_error_handlers genwqe_err_handler = { > .error_detected = genwqe_err_error_detected, > .mmio_enabled = genwqe_err_result_none, > .slot_reset = genwqe_err_slot_reset,
Good idea. Thanks for the contribution.
Signed-off-by: Frank Haverkamp <haver@linux.ibm.com>
| |