lkml.org 
[lkml]   [2020]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 2/3] media: rcar-csi2: Add warning for PHY speed less than minimum
Hi Suresh,

Thanks for your patch.

On 2020-06-18 19:34:31 +0900, Suresh Udipi wrote:
> Add a warning message when the selected PHY speed is less
> than supported minimum PHY speed given in the hsfreq table[1].
>
> For raspberry pi camera capture on Kingfisher board with resolution
> 640x480, the calculated PHY speed is 48 mbps which is less than
> the minimum PHY speed 80 Mbps from the table[1]. But in this cases
> capture is successful.
>
> [1] specs r19uh0105ej0200-r-car-3rd-generation.pdf [Table 25.9]
>
> Signed-off-by: Suresh Udipi <sudipi@jp.adit-jv.com>
> Signed-off-by: Michael Rodin <mrodin@de.adit-jv.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> ---
> drivers/media/platform/rcar-vin/rcar-csi2.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c
> index f18dedc..1184527 100644
> --- a/drivers/media/platform/rcar-vin/rcar-csi2.c
> +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
> @@ -433,6 +433,10 @@ static int rcsi2_set_phypll(struct rcar_csi2 *priv, unsigned int mbps)
> const struct rcsi2_mbps_reg *hsfreq;
> const struct rcsi2_mbps_reg *hsfreq_prev = NULL;
>
> + if (mbps < priv->info->hsfreqrange->mbps)
> + dev_warn(priv->dev, "%u Mbps less than min PHY speed %u Mbps",
> + mbps, priv->info->hsfreqrange->mbps);
> +
> for (hsfreq = priv->info->hsfreqrange; hsfreq->mbps != 0; hsfreq++) {
> if (hsfreq->mbps >= mbps)
> break;
> --
> 2.7.4
>

--
Regards,
Niklas Söderlund

\
 
 \ /
  Last update: 2020-07-01 00:06    [W:0.105 / U:0.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site