Messages in this thread | | | Subject | Re: [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq | From | "Herrenschmidt, Benjamin" <> | Date | Wed, 3 Jun 2020 22:14:50 +0000 |
| |
On Wed, 2020-06-03 at 16:16 +0100, Marc Zyngier wrote: > > My original patch should certain check activated and not disabled. > > With that do you still have reservations Marc? > > I'd still prefer it if we could do something in core code, rather > than spreading these checks in the individual drivers. If we can't, > fair enough. But it feels like the core set_affinity function could > just do the same thing in a single place (although the started vs > activated is yet another piece of the puzzle I didn't consider, > and the ITS doesn't need the "can_reserve" thing).
For the sake of fixing the problem in a timely and backportable way I would suggest first merging the fix, *then* fixing the core core.
Cheers, Ben.
| |