Messages in this thread | | | Subject | Re: [PATCH] clk: clk-st: Add missed return value checks in st_clk_probe() | From | Markus Elfring <> | Date | Wed, 3 Jun 2020 19:30:46 +0200 |
| |
> st_clk_probe() has not check for clk_hw_register_mux(), clk_hw_register_gate() > and devm_clk_hw_register_clkdev(). > Add the missed checks and return devm_clk_hw_register_clkdev()'s return value > to check errors.
How do you think about another wording variant?
Return values were not checked after calls of the following functions. - clk_hw_register_mux - clk_hw_register_gate - devm_clk_hw_register_clkdev
* Thus add error detection and the corresponding exception handling.
* Return the value from the function call “devm_clk_hw_register_clkdev” at the end of this function implementation.
Regards, Markus
| |