lkml.org 
[lkml]   [2020]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] lan743x: Added fixed link and RGMII support / Options for proceeding ?
From
Date
Hi,

we need to decide how to continue with the lan743x patch for fixed phy support. Thanks everyone for the valuable time.

Summary of the development steps so far:
The patch initially had low influence on the installed base, but lacked some compatibility to Linux best practices. During the review process we found improvement potential. We decided to make the patch more similar to the majority of Linux drivers, by avoiding a special autodetection silicon feature that is unique. However, now, with more test hardware available, this road becomes more difficult than we initially assumed.

Would it be ok to split the topics into two distinct patches ?

Topic a: New feature: Add fixed link and RGMII support in a minimal invasive way. (Including fixing a reboot-issue that the last patch fixed.)

Topic b: Refactor old driver: Understand, and if possible remove, the silicon’s Mac-Phy auto-negotiation feature.

Maybe splitting distinct features into distinct patches is the most defensive approach, now that device testing disconfirmed our promising approach ?

Thanks everyone for cooperating on this feature,
Roelof


> Roelof Berg <rberg@berg-solutions.de>:
>
> Testing note [...]
> - Different from prior approaches it affects the installed base. So we need some more testing (with hardware I don’t have available yet) and I’m in contact with Microchip already.
>
> Thanks for guiding us to a proper solution,
> Roelof Berg
>
>> . The automatic speed and duplex detection of the lan743x silicon
>> between mac and phy is disabled.

\
 
 \ /
  Last update: 2020-06-03 17:11    [W:0.163 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site