Messages in this thread Patch in this message | | | From | Piotr Stankiewicz <> | Subject | [PATCH v2 08/15] IB/qib: Use PCI_IRQ_MSI_TYPES where appropriate | Date | Wed, 3 Jun 2020 13:48:17 +0200 |
| |
Seeing as there is shorthand available to use when asking for any type of interrupt, or any type of message signalled interrupt, leverage it.
Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@intel.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com> --- drivers/infiniband/hw/qib/qib_pcie.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/qib/qib_pcie.c b/drivers/infiniband/hw/qib/qib_pcie.c index 3dc6ce033319..caff44d2c12c 100644 --- a/drivers/infiniband/hw/qib/qib_pcie.c +++ b/drivers/infiniband/hw/qib/qib_pcie.c @@ -213,7 +213,7 @@ int qib_pcie_params(struct qib_devdata *dd, u32 minw, u32 *nent) u16 linkstat, speed; int nvec; int maxvec; - unsigned int flags = PCI_IRQ_MSIX | PCI_IRQ_MSI; + unsigned int flags; if (!pci_is_pcie(dd->pcidev)) { qib_dev_err(dd, "Can't find PCI Express capability!\n"); @@ -225,7 +225,9 @@ int qib_pcie_params(struct qib_devdata *dd, u32 minw, u32 *nent) } if (dd->flags & QIB_HAS_INTX) - flags |= PCI_IRQ_LEGACY; + flags = PCI_IRQ_ALL_TYPES; + else + flags = PCI_IRQ_MSI_TYPES; maxvec = (nent && *nent) ? *nent : 1; nvec = pci_alloc_irq_vectors(dd->pcidev, 1, maxvec, flags); if (nvec < 0) -- 2.17.2
| |