lkml.org 
[lkml]   [2020]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 5/6] iio: light: lm3533-als: use iio_device_set_parent() to assign parent
    Date
    This assignment is the more peculiar as it assigns the parent of the
    platform-device's device (i.e. pdev->dev.parent) as the IIO device's
    parent.

    Since the devm_iio_device_alloc() [now] assigns the device argument as the
    default parent (and since this is the more common case), for cases
    where the parent needs to be different, the iio_device_set_parent helper
    should be used.

    That makes things a bit more obvious about the new behavior of
    devm_iio_device_alloc() and makes it clearer that iio_device_set_parent()
    should be used.

    Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
    ---
    drivers/iio/light/lm3533-als.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c
    index bc196c212881..8a621244dd01 100644
    --- a/drivers/iio/light/lm3533-als.c
    +++ b/drivers/iio/light/lm3533-als.c
    @@ -852,7 +852,7 @@ static int lm3533_als_probe(struct platform_device *pdev)
    indio_dev->channels = lm3533_als_channels;
    indio_dev->num_channels = ARRAY_SIZE(lm3533_als_channels);
    indio_dev->name = dev_name(&pdev->dev);
    - indio_dev->dev.parent = pdev->dev.parent;
    + iio_device_set_parent(indio_dev, pdev->dev.parent);
    indio_dev->modes = INDIO_DIRECT_MODE;

    als = iio_priv(indio_dev);
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-03 13:41    [W:5.177 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site