Messages in this thread | | | From | Steve Lee <> | Subject | RE: [PATCH] ASoC: max98390: Fix potential crash during param fw loading | Date | Wed, 3 Jun 2020 11:30:02 +0000 |
| |
> -----Original Message----- > From: Takashi Iwai <tiwai@suse.de> > Sent: Wednesday, June 3, 2020 8:24 PM > To: Steve Lee <SteveS.Lee@maximintegrated.com> > Cc: lgirdwood@gmail.com; broonie@kernel.org; perex@perex.cz; > tiwai@suse.com; ckeepax@opensource.cirrus.com; geert@linux-m68k.org; > rf@opensource.wolfsonmicro.com; shumingf@realtek.com; > srinivas.kandagatla@linaro.org; krzk@kernel.org; dmurphy@ti.com; > jack.yu@realtek.com; nuno.sa@analog.com; linux-kernel@vger.kernel.org; > alsa-devel@alsa-project.org; ryan.lee.maxim@gmail.com; Ryan Lee > <RyanS.Lee@maximintegrated.com>; steves.lee.maxim@gmail.com > Subject: Re: [PATCH] ASoC: max98390: Fix potential crash during param fw > loading > > EXTERNAL EMAIL > > > > On Wed, 03 Jun 2020 13:18:19 +0200, > Steve Lee wrote: > > > > @@ -847,7 +861,6 @@ static int max98390_probe(struct snd_soc_component > *component) > > > > /* Dsm Setting */ > > regmap_write(max98390->regmap, DSM_VOL_CTRL, 0x94); > > - regmap_write(max98390->regmap, DSMIG_EN, 0x19); > > Is this change intentional? > It wasn't mentioned in the patch description.
It should be another change. I will re-send the patch.
> > > thanks, > > Takashi
| |