lkml.org 
[lkml]   [2020]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 14/15] net: hns3: use PCI_IRQ_MSI_TYPES where appropriate
Date
> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: Tuesday, June 2, 2020 5:39 PM
>
> On Tue, Jun 2, 2020 at 12:26 PM Piotr Stankiewicz
> <piotr.stankiewicz@intel.com> wrote:
> >
> > Seeing as there is shorthand available to use when asking for any type
> > of interrupt, or any type of message signalled interrupt, leverage it.
>
> ...
>
> > vectors = pci_alloc_irq_vectors(pdev, HNAE3_MIN_VECTOR_NUM,
> > - hdev->num_msi,
> > - PCI_IRQ_MSI | PCI_IRQ_MSIX);
> > + hdev->num_msi, PCI_IRQ_MSI_TYPES);
>
> ...
>
> > vectors = pci_alloc_irq_vectors(pdev, HNAE3_MIN_VECTOR_NUM,
>
> > hdev->num_msi,
> > - PCI_IRQ_MSI | PCI_IRQ_MSIX);
> > + PCI_IRQ_MSI_TYPES);
>
> One line as above?
>

It would push the line above 80 characters.

> --
> With Best Regards,
> Andy Shevchenko

BR,
Piotr
\
 
 \ /
  Last update: 2020-06-03 10:50    [W:0.164 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site