Messages in this thread | | | Subject | Re: drm/nouveau/clk/gm20b: Understanding challenges around gm20b_clk_new() | From | Markus Elfring <> | Date | Wed, 3 Jun 2020 07:04:37 +0200 |
| |
> Ben has explained this problem: > https://lore.kernel.org/patchwork/patch/1249592/ > Since the caller will check "pclk" on failure, we don't need to free > "clk" in gm20b_clk_new() and I think this patch is no longer needed.
* I am curious if it can become easier to see the relationships for these variables according to mentioned “destructor” calls.
* Did you notice opportunities to improve source code analysis (or software documentation) accordingly?
Regards, Markus
| |