lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 088/178] RDMA/mad: Fix possible memory leak in ib_mad_post_receive_mads()
    Date
    From: Fan Guo <guofan5@huawei.com>

    [ Upstream commit a17f4bed811c60712d8131883cdba11a105d0161 ]

    If ib_dma_mapping_error() returns non-zero value,
    ib_mad_post_receive_mads() will jump out of loops and return -ENOMEM
    without freeing mad_priv. Fix this memory-leak problem by freeing mad_priv
    in this case.

    Fixes: 2c34e68f4261 ("IB/mad: Check and handle potential DMA mapping errors")
    Link: https://lore.kernel.org/r/20200612063824.180611-1-guofan5@huawei.com
    Signed-off-by: Fan Guo <guofan5@huawei.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/core/mad.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c
    index a9e00cdf717b8..2284930b5f915 100644
    --- a/drivers/infiniband/core/mad.c
    +++ b/drivers/infiniband/core/mad.c
    @@ -2960,6 +2960,7 @@ static int ib_mad_post_receive_mads(struct ib_mad_qp_info *qp_info,
    DMA_FROM_DEVICE);
    if (unlikely(ib_dma_mapping_error(qp_info->port_priv->device,
    sg_list.addr))) {
    + kfree(mad_priv);
    ret = -ENOMEM;
    break;
    }
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-29 22:01    [W:2.069 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site