lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v4 08/17] arm64/mm: Remove needless section quotes
    On Sun, Jun 28, 2020 at 11:18 PM Kees Cook <keescook@chromium.org> wrote:
    >
    > Fix a case of needless quotes in __section(), which Clang doesn't like.
    >
    > Acked-by: Will Deacon <will@kernel.org>
    > Signed-off-by: Kees Cook <keescook@chromium.org>

    Yep, I remember bugs from this. Probably should scan the kernel for
    other instances of this. +Joe for checkpatch.pl validation.
    Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

    > ---
    > arch/arm64/mm/mmu.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
    > index 1df25f26571d..dce024ea6084 100644
    > --- a/arch/arm64/mm/mmu.c
    > +++ b/arch/arm64/mm/mmu.c
    > @@ -42,7 +42,7 @@
    > u64 idmap_t0sz = TCR_T0SZ(VA_BITS);
    > u64 idmap_ptrs_per_pgd = PTRS_PER_PGD;
    >
    > -u64 __section(".mmuoff.data.write") vabits_actual;
    > +u64 __section(.mmuoff.data.write) vabits_actual;
    > EXPORT_SYMBOL(vabits_actual);
    >
    > u64 kimage_voffset __ro_after_init;
    > --
    > 2.25.1
    >


    --
    Thanks,
    ~Nick Desaulniers

    \
     
     \ /
      Last update: 2020-06-29 21:54    [W:2.442 / U:0.480 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site