lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 121/178] hwrng: ks-sa - Fix runtime PM imbalance on error
    Date
    From: Dinghao Liu <dinghao.liu@zju.edu.cn>

    [ Upstream commit 95459261c99f1621d90bc628c2a48e60b7cf9a88 ]

    pm_runtime_get_sync() increments the runtime PM usage counter even
    the call returns an error code. Thus a pairing decrement is needed
    on the error handling path to keep the counter balanced.

    Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
    Reviewed-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/char/hw_random/ks-sa-rng.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/char/hw_random/ks-sa-rng.c b/drivers/char/hw_random/ks-sa-rng.c
    index a67430010aa68..5c7d3dfcfdd04 100644
    --- a/drivers/char/hw_random/ks-sa-rng.c
    +++ b/drivers/char/hw_random/ks-sa-rng.c
    @@ -208,6 +208,7 @@ static int ks_sa_rng_probe(struct platform_device *pdev)
    ret = pm_runtime_get_sync(dev);
    if (ret < 0) {
    dev_err(dev, "Failed to enable SA power-domain\n");
    + pm_runtime_put_noidle(dev);
    pm_runtime_disable(dev);
    return ret;
    }
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-29 21:43    [W:9.517 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site