Messages in this thread | | | Date | Mon, 29 Jun 2020 21:41:13 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH 2/4] pwm: bcm-kona: Remove impossible comparison when validating duty cycle |
| |
On Mon, Jun 29, 2020 at 09:45:31AM -0700, Florian Fainelli wrote: > > > On 6/29/2020 5:47 AM, Lee Jones wrote: > > 'dc' here is an unsigned long, thus checking for <0 will always > > evaluate to false. > > > > Fixes the following W=1 warning: > > > > drivers/pwm/pwm-bcm-kona.c:141:35: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] > > > > Cc: Florian Fainelli <f.fainelli@gmail.com> > > Cc: Ray Jui <rjui@broadcom.com> > > Cc: Scott Branden <sbranden@broadcom.com> > > Cc: bcm-kernel-feedback-list@broadcom.com > > Cc: linux-pwm@vger.kernel.org > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > And similar to patch #1, DUTY_CYCLE_HIGH_MIN now gets unused, so if you > remove it as well, you can add: > > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Even without removing DUTY_CYCLE_HIGH_MIN (which might still serve as documentation):
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |