| Date | Mon, 29 Jun 2020 08:53:06 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v3 3/7] x86/boot/compressed: Get rid of GOT fixup code |
| |
On Mon, Jun 29, 2020 at 10:09:24AM -0400, Arvind Sankar wrote: > From: Ard Biesheuvel <ardb@kernel.org> > > In a previous patch, we have eliminated GOT entries from the decompressor > binary and added an assertion that the .got section is empty. This means > that the GOT fixup routines that exist in both the 32-bit and 64-bit > startup routines have become dead code, and can be removed. > > While at it, drop the KEEP() from the linker script, as it has no effect > on the contents of output sections that are created by the linker itself. > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org> > Acked-by: Arvind Sankar <nivedita@alum.mit.edu> > Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu> > From: Ard Biesheuvel <ardb@kernel.org> > Link: https://lore.kernel.org/r/20200523120021.34996-4-ardb@kernel.org > --- > arch/x86/boot/compressed/head_32.S | 24 ++--------- > arch/x86/boot/compressed/head_64.S | 57 -------------------------- > arch/x86/boot/compressed/vmlinux.lds.S | 4 +- > 3 files changed, 5 insertions(+), 80 deletions(-)
This makes me very happy! This code always bugged me. ;)
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
|