Messages in this thread | | | From | Ian Rogers <> | Date | Mon, 29 Jun 2020 08:49:38 -0700 | Subject | Re: [PATCH 02/10] perf tools: Add struct expr_parse_data to keep expr value |
| |
On Sun, Jun 28, 2020 at 2:25 PM Jiri Olsa <jolsa@redhat.com> wrote: > > On Fri, Jun 26, 2020 at 01:04:41PM -0700, Ian Rogers wrote: > > On Fri, Jun 26, 2020 at 12:47 PM Jiri Olsa <jolsa@kernel.org> wrote: > > > > > > Adding struct expr_parse_data to keep expr value > > > instead of just simple double pointer, so we can > > > store more data for ID in following changes. > > > > Nit, expr_parse_data sounds a bit like data that is created just at > > parse time. Perhaps id_data, for data associated with an id? > > we should keep the expr prefix, expr_id_data ?
Sounds good to me. Thanks, Ian
> jirka >
| |