lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 166/265] qed: add missing error test for DBG_STATUS_NO_MATCHING_FRAMING_MODE
    Date
    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit a51243860893615b457b149da1ef5df0a4f1ffc2 ]

    The error DBG_STATUS_NO_MATCHING_FRAMING_MODE was added to the enum
    enum dbg_status however there is a missing corresponding entry for
    this in the array s_status_str. This causes an out-of-bounds read when
    indexing into the last entry of s_status_str. Fix this by adding in
    the missing entry.

    Addresses-Coverity: ("Out-of-bounds read").
    Fixes: 2d22bc8354b1 ("qed: FW 8.42.2.0 debug features")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/qlogic/qed/qed_debug.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c b/drivers/net/ethernet/qlogic/qed/qed_debug.c
    index f4eebaabb6d0d..3e56b6056b477 100644
    --- a/drivers/net/ethernet/qlogic/qed/qed_debug.c
    +++ b/drivers/net/ethernet/qlogic/qed/qed_debug.c
    @@ -5568,7 +5568,8 @@ static const char * const s_status_str[] = {

    /* DBG_STATUS_INVALID_FILTER_TRIGGER_DWORDS */
    "The filter/trigger constraint dword offsets are not enabled for recording",
    -
    + /* DBG_STATUS_NO_MATCHING_FRAMING_MODE */
    + "No matching framing mode",

    /* DBG_STATUS_VFC_READ_ERROR */
    "Error reading from VFC",
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-29 20:38    [W:5.555 / U:0.748 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site