Messages in this thread | | | From | <> | Subject | Re: [PATCH v1] mtd: spi-nor: Add support for Winbond w25q64jv spi flash | Date | Mon, 29 Jun 2020 19:01:51 +0000 |
| |
On 6/29/20 5:53 PM, Sven Van Asbroeck wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Hi Tudor, > > On Mon, Jun 29, 2020 at 8:50 AM <Tudor.Ambarus@microchip.com> wrote: >> >> I'm reading the following datasheet: >> https://www.winbond.com/resource-files/w25q64jv%20revj%2003272018%20plus.pdf >> >> w25q64jvm (0xef7017) comes with QE bit set to a 0 state, but can be >> set to 1, so Quad mode can be supported. Would you please set SPI_NOR_DUAL_READ >> and SPI_NOR_QUAD_READ flags and test and see if Quad works? If all good, >> please specify in the commit message with which controller you did the tests. >> > > Good point ! > > Unfortunately I'm using the spi controller on an imx6 ("fsl,imx51-ecspi") which > does not support dual or quad mode. So I cannot possibly test this :) > > How would you like to proceed? Should I keep this as a private patch, and > wait until someone comes along who can test this on more capable > controller h/w ? > > Or should I re-spin the patch without the flags? >
Re-spin the patch without the flags. We can add them later on, when someone can test them.
Cheers, ta
| |