Messages in this thread | | | Subject | Re: [PATCH 1/2] KVM: SVM: fix svn_pin_memory()'s use of get_user_pages_fast() | From | John Hubbard <> | Date | Mon, 29 Jun 2020 20:10:41 -0700 |
| |
On 2020-05-26 00:33, Vitaly Kuznetsov wrote: ... > I bit unrelated to this patch, but callers of sev_pin_memory() treat > NULL differently: > > sev_launch_secret()/svm_register_enc_region() return -ENOMEM > sev_dbg_crypt() returns -EFAULT > > Should we switch to ERR_PTR() to preserve the error? > >> /* Avoid using vmalloc for smaller buffers. */ >> size = npages * sizeof(struct page *); >> if (size > PAGE_SIZE) > > Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com> >
Thanks for the review, Vitaly. If anyone is able to do any run-time testing of this patch and also patch 2/2, then I think a maintainer would be more willing to pick them up.
Any testing help there is greatly appreciated!
thanks, -- John Hubbard NVIDIA
| |