Messages in this thread | | | Subject | Re: [PATCH v6 1/6] tty: serial: qcom_geni_serial: Use OPP API to set clk/perf state | From | Rajendra Nayak <> | Date | Tue, 30 Jun 2020 08:31:02 +0530 |
| |
On 6/30/2020 4:47 AM, Stephen Boyd wrote: > Quoting Rajendra Nayak (2020-06-15 05:02:39) >> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c >> index 457c0bf..a90f8ec 100644 >> --- a/drivers/tty/serial/qcom_geni_serial.c >> +++ b/drivers/tty/serial/qcom_geni_serial.c >> @@ -9,6 +9,7 @@ >> #include <linux/module.h> >> #include <linux/of.h> >> #include <linux/of_device.h> >> +#include <linux/pm_opp.h> >> #include <linux/platform_device.h> >> #include <linux/pm_runtime.h> >> #include <linux/pm_wakeirq.h> >> @@ -962,7 +963,7 @@ static void qcom_geni_serial_set_termios(struct uart_port *uport, >> goto out_restart_rx; >> >> uport->uartclk = clk_rate; >> - clk_set_rate(port->se.clk, clk_rate); >> + dev_pm_opp_set_rate(uport->dev, clk_rate); > > If there isn't an OPP table for the device because it is optional then > how can we unconditionally call dev_pm_opp_set_rate()?
because we have 'aca48b6 opp: Manage empty OPP tables with clk handle' to handle this.
-- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
| |