lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 095/265] bus: ti-sysc: Ignore clockactivity unless specified as a quirk
    Date
    From: Tony Lindgren <tony@atomide.com>

    [ Upstream commit 08b91dd6e547467fad61a7c201ff71080d7ad65a ]

    We must ignore the clockactivity bit for most modules and not set it
    unless specified for the module with SYSC_QUIRK_USE_CLOCKACT. Otherwise
    the interface clock can be automatically gated constantly causing
    unexpected performance issues.

    Fixes: ae9ae12e9daa ("bus: ti-sysc: Handle clockactivity for enable and disable")
    Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
    Signed-off-by: Tony Lindgren <tony@atomide.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/bus/ti-sysc.c | 9 ++++++---
    1 file changed, 6 insertions(+), 3 deletions(-)

    diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
    index a3a2c269e9ad7..4f640a635ded1 100644
    --- a/drivers/bus/ti-sysc.c
    +++ b/drivers/bus/ti-sysc.c
    @@ -988,10 +988,13 @@ static int sysc_enable_module(struct device *dev)
    regbits = ddata->cap->regbits;
    reg = sysc_read(ddata, ddata->offsets[SYSC_SYSCONFIG]);

    - /* Set CLOCKACTIVITY, we only use it for ick */
    + /*
    + * Set CLOCKACTIVITY, we only use it for ick. And we only configure it
    + * based on the SYSC_QUIRK_USE_CLOCKACT flag, not based on the hardware
    + * capabilities. See the old HWMOD_SET_DEFAULT_CLOCKACT flag.
    + */
    if (regbits->clkact_shift >= 0 &&
    - (ddata->cfg.quirks & SYSC_QUIRK_USE_CLOCKACT ||
    - ddata->cfg.sysc_val & BIT(regbits->clkact_shift)))
    + (ddata->cfg.quirks & SYSC_QUIRK_USE_CLOCKACT))
    reg |= SYSC_CLOCACT_ICK << regbits->clkact_shift;

    /* Set SIDLE mode */
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-29 23:58    [W:4.148 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site