lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 236/265] mm/memcontrol.c: add missed css_put()
    Date
    From: Muchun Song <songmuchun@bytedance.com>

    commit 3a98990ae2150277ed34d3b248c60e68bf2244b2 upstream.

    We should put the css reference when memory allocation failed.

    Link: http://lkml.kernel.org/r/20200614122653.98829-1-songmuchun@bytedance.com
    Fixes: f0a3a24b532d ("mm: memcg/slab: rework non-root kmem_cache lifecycle management")
    Signed-off-by: Muchun Song <songmuchun@bytedance.com>
    Acked-by: Roman Gushchin <guro@fb.com>
    Acked-by: Michal Hocko <mhocko@suse.com>
    Cc: Johannes Weiner <hannes@cmpxchg.org>
    Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
    Cc: Qian Cai <cai@lca.pw>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    mm/memcontrol.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/mm/memcontrol.c b/mm/memcontrol.c
    index 1b05e25d8aef2..ef0e291a8cf46 100644
    --- a/mm/memcontrol.c
    +++ b/mm/memcontrol.c
    @@ -2790,8 +2790,10 @@ static void memcg_schedule_kmem_cache_create(struct mem_cgroup *memcg,
    return;

    cw = kmalloc(sizeof(*cw), GFP_NOWAIT | __GFP_NOWARN);
    - if (!cw)
    + if (!cw) {
    + css_put(&memcg->css);
    return;
    + }

    cw->memcg = memcg;
    cw->cachep = cachep;
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-29 23:48    [W:3.106 / U:1.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site