lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 10/20] misc: habanalabs: gaudi: gaudi_security: Repair incorrectly named function arg
    On Mon, Jun 29, 2020 at 5:04 PM Lee Jones <lee.jones@linaro.org> wrote:
    >
    > audi_pb_set_block()'s argument 'base' was incorrectly named 'block' in
    gaudi_pb_set_block()'s

    > its function header.
    >
    > Fixes the following W=1 kernel build warning(s):
    >
    > drivers/misc/habanalabs/gaudi/gaudi_security.c:454: warning: Function parameter or member 'base' not described in 'gaudi_pb_set_block'
    > drivers/misc/habanalabs/gaudi/gaudi_security.c:454: warning: Excess function parameter 'block' description in 'gaudi_pb_set_block'
    >
    > Cc: Oded Gabbay <oded.gabbay@gmail.com>
    > Cc: Tomer Tayar <ttayar@habana.ai>
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>
    > ---
    > drivers/misc/habanalabs/gaudi/gaudi_security.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/drivers/misc/habanalabs/gaudi/gaudi_security.c b/drivers/misc/habanalabs/gaudi/gaudi_security.c
    > index 6a351e31fa6af..abdd5ed8f2cf6 100644
    > --- a/drivers/misc/habanalabs/gaudi/gaudi_security.c
    > +++ b/drivers/misc/habanalabs/gaudi/gaudi_security.c
    > @@ -447,8 +447,7 @@ static u64 gaudi_rr_hbw_mask_high_ar_regs[GAUDI_NUMBER_OF_RR_REGS] = {
    > * gaudi_set_block_as_protected - set the given block as protected
    > *
    > * @hdev: pointer to hl_device structure
    > - * @block: block base address
    > - *
    > + * @base: block base address
    > */
    > static void gaudi_pb_set_block(struct hl_device *hdev, u64 base)
    > {
    > --
    > 2.25.1
    >
    With the above fix, This patch is:
    Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>

    \
     
     \ /
      Last update: 2020-06-29 23:29    [W:3.810 / U:1.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site