Messages in this thread | | | Date | Mon, 29 Jun 2020 14:09:38 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] lib: Extend kstrtobool() to accept "true"/"false" |
| |
Hi!
> > > This is too lax - it will be enabled for any !0 value. Please accept > > > only 0 and 1. > > > > kstrtobool() ftw > > And looking at that, I find it really strange it does not in fact accept > "true" / "false", so how about this? > > --- > Subject: lib: Extend kstrtobool() to accept "true"/"false" > > Extend the strings recognised by kstrtobool() to cover: > > - 1/0 > - y/n > - yes/no (new) > - t/f (new) > - true/false (new) > - on/off
Is it good idea to add more values there? It is easy to do, but... we don't want people to use this by hand, and ideally everyone would just use 1/0...
I also see potential for confusion... as in echo off > enable_off_mode (ok, this is with existing code, but...)
Plus, if programs learn to do "echo true > ..." they will stop working on older kernels.
Plus, this really should be documented somewhere, as it is kernel ABI.
IMO this does not need changing.
NAK.
Best regards, Pavel
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |