lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 3/3] ARM: imx: Select RESET_IMX7 for i.MX7D
    Date
    Hi, Arnd


    > Subject: Re: [PATCH 3/3] ARM: imx: Select RESET_IMX7 for i.MX7D
    >
    > On Mon, Jun 29, 2020 at 12:25 PM Anson Huang <Anson.Huang@nxp.com>
    > wrote:
    > >
    > > i.MX7 reset driver now supports module build, it is no longer built in
    > > by default, need to select it explicitly for i.MX7D.
    > >
    > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
    > > ---
    > > arch/arm/mach-imx/Kconfig | 1 +
    > > 1 file changed, 1 insertion(+)
    > >
    > > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
    > > index e7d7b90..3540483 100644
    > > --- a/arch/arm/mach-imx/Kconfig
    > > +++ b/arch/arm/mach-imx/Kconfig
    > > @@ -561,6 +561,7 @@ config SOC_IMX7D_CM4 config SOC_IMX7D
    > > bool "i.MX7 Dual support"
    > > select PINCTRL_IMX7D
    > > + select RESET_IMX7
    >
    > Please drop this patch, it breaks the intent of the first one by forcing the driver
    > to be built-in again rather than a loadable module.
    >

    One thing to clarify is, the loadable module support is ONLY for i.MX ARMv8 SoCs,
    ARMv7 SoCs is NOT in the plan, that is why I add this patch to make it same as previously
    when this reset driver is =y by default. Without this patch, this reset driver will NOT be
    enabled by default for i.MX ARMv7 SoCs, function will be broken.

    Thanks,
    Anson
    \
     
     \ /
      Last update: 2020-06-29 22:52    [W:8.354 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site