Messages in this thread | | | Subject | Re: [PATCH 01/11] kexec_file: allow archs to handle special regions while locating memory hole | From | Hari Bathini <> | Date | Mon, 29 Jun 2020 11:30:35 +0530 |
| |
On 28/06/20 7:58 am, piliu wrote: > Hi Hari, > > If in [4/11], get_exclude_memory_ranges() turns out to be unnecessary > ,then this patch is abundant either. As my understanding, memblock has > already helped to achieved the purpose that get_exclude_memory_ranges() > wants.
As mentioned in the other patch, there is a need for @exclude_ranges as crashkernel region is likely to have an overlap with regions like opal, rtas..
But yeah.. the weak function should have been kexec_locate_mem_hole() instead of kexec_add_buffer(). Will take care of that in v2.
> On 06/27/2020 03:04 AM, Hari Bathini wrote: >> Some archs can have special memory regions, within the given memory >> range, which can't be used for the buffer in a kexec segment. As >> kexec_add_buffer() function is being called from generic code as well, >> add weak arch_kexec_add_buffer definition for archs to override & take >> care of special regions before trying to locate a memory hole. >> >> Signed-off-by: Hari Bathini <hbathini@linux.ibm.com>
Thanks Hari
| |