lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V4 3/3] cpufreq: Specify default governor on command line
    On Monday 29 Jun 2020 at 13:55:00 (+0530), Viresh Kumar wrote:
    > static int __init cpufreq_core_init(void)
    > {
    > + struct cpufreq_governor *gov = cpufreq_default_governor();
    > +
    > if (cpufreq_disabled())
    > return -ENODEV;
    >
    > cpufreq_global_kobject = kobject_create_and_add("cpufreq", &cpu_subsys.dev_root->kobj);
    > BUG_ON(!cpufreq_global_kobject);
    >
    > + if (!strlen(default_governor))

    Should we test '!strlen(default_governor) && gov' here actually?
    We check the return value of cpufreq_default_governor() in
    cpufreq_init_policy(), so I'm guessing we should do the same here to be
    on the safe side.

    > + strncpy(default_governor, gov->name, CPUFREQ_NAME_LEN);
    > +
    > return 0;
    > }
    > module_param(off, int, 0444);
    > +module_param_string(default_governor, default_governor, CPUFREQ_NAME_LEN, 0444);
    > core_initcall(cpufreq_core_init);
    > --
    > 2.25.0.rc1.19.g042ed3e048af


    Other than that, the whole series looks good to me.

    Thanks,
    Quentin

    \
     
     \ /
      Last update: 2020-06-29 22:47    [W:3.556 / U:0.740 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site