lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 150/191] usb: host: ehci-exynos: Fix error check in exynos_ehci_probe()
    Date
    From: Tang Bin <tangbin@cmss.chinamobile.com>

    commit 44ed240d62736ad29943ec01e41e194b96f7c5e9 upstream.

    If the function platform_get_irq() failed, the negative value
    returned will not be detected here. So fix error handling in
    exynos_ehci_probe(). And when get irq failed, the function
    platform_get_irq() logs an error message, so remove redundant
    message here.

    Fixes: 1bcc5aa87f04 ("USB: Add initial S5P EHCI driver")
    Cc: stable <stable@vger.kernel.org>
    Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
    Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
    Link: https://lore.kernel.org/r/20200602114708.28620-1-tangbin@cmss.chinamobile.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/host/ehci-exynos.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c
    index 7a603f66a9bc5..44b7c3e780f67 100644
    --- a/drivers/usb/host/ehci-exynos.c
    +++ b/drivers/usb/host/ehci-exynos.c
    @@ -199,9 +199,8 @@ static int exynos_ehci_probe(struct platform_device *pdev)
    hcd->rsrc_len = resource_size(res);

    irq = platform_get_irq(pdev, 0);
    - if (!irq) {
    - dev_err(&pdev->dev, "Failed to get IRQ\n");
    - err = -ENODEV;
    + if (irq < 0) {
    + err = irq;
    goto fail_io;
    }

    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-29 22:39    [W:4.067 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site