lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 083/191] drm/qxl: Use correct notify port address when creating cursor ring
    Date
    From: Huacai Chen <chenhc@lemote.com>

    commit 80e5f89da3ab949fbbf1cae01dfaea29f5483a75 upstream.

    The command ring and cursor ring use different notify port addresses
    definition: QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR. However, in
    qxl_device_init() we use QXL_IO_NOTIFY_CMD to create both command ring
    and cursor ring. This doesn't cause any problems now, because QEMU's
    behaviors on QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR are the same.
    However, QEMU's behavior may be change in future, so let's fix it.

    P.S.: In the X.org QXL driver, the notify port address of cursor ring
    is correct.

    Signed-off-by: Huacai Chen <chenhc@lemote.com>
    Cc: <stable@vger.kernel.org>
    Link: http://patchwork.freedesktop.org/patch/msgid/1585635488-17507-1-git-send-email-chenhc@lemote.com
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpu/drm/qxl/qxl_kms.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/qxl/qxl_kms.c b/drivers/gpu/drm/qxl/qxl_kms.c
    index e642242728c0b..a886652ed895b 100644
    --- a/drivers/gpu/drm/qxl/qxl_kms.c
    +++ b/drivers/gpu/drm/qxl/qxl_kms.c
    @@ -199,7 +199,7 @@ static int qxl_device_init(struct qxl_device *qdev,
    &(qdev->ram_header->cursor_ring_hdr),
    sizeof(struct qxl_command),
    QXL_CURSOR_RING_SIZE,
    - qdev->io_base + QXL_IO_NOTIFY_CMD,
    + qdev->io_base + QXL_IO_NOTIFY_CURSOR,
    false,
    &qdev->cursor_event);

    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-29 22:33    [W:4.074 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site