Messages in this thread | | | From | Yoshihiro Shimoda <> | Subject | RE: [PATCH/RFC v4 3/4] mmc: core: Call mmc_poweroff_nofity() if regulators are disabled | Date | Mon, 29 Jun 2020 02:49:30 +0000 |
| |
Hi Mark,
> From: Mark Brown, Sent: Saturday, June 27, 2020 12:14 AM > > On Fri, Jun 26, 2020 at 06:32:21PM +0900, Yoshihiro Shimoda wrote: > > Note that this is possible to happen when the regulator-fixed driver > > turns the vmmc and vqmmc off by firmware like PSCI while the system > > is suspended. > > This is not a good interface, if there's a need to query the state over > suspend then we should query the state over suspend rather than trying > to somehow shoehorn it via the runtime enable state which is going to > break any other users and relies on the regulator driver doing dodgy > stuff representing the enable state.
I understood it. So, as I mentioned other email thread, I'm thinking adding a new property into MMC is better.
Best regards, Yoshihiro Shimoda
| |