Messages in this thread | | | From | Pkshih <> | Subject | Re: [PATCH] rtlwifi/*/dm.c: Use const in swing_table declarations | Date | Mon, 29 Jun 2020 02:09:24 +0000 |
| |
On Sun, 2020-06-28 at 03:17 -0700, Joe Perches wrote:
Use 'rtlwifi:' as subject title prefix is enough, likes rtlwifi: Use const in swing_table declarations
> Reduce data usage about 1KB by using const. > > Signed-off-by: Joe Perches <joe@perches.com> > --- > .../net/wireless/realtek/rtlwifi/rtl8188ee/dm.c | 4 +- > .../net/wireless/realtek/rtlwifi/rtl8723be/dm.c | 4 +- > .../net/wireless/realtek/rtlwifi/rtl8821ae/dm.c | 98 ++++++++++++--------- > - > 3 files changed, 56 insertions(+), 50 deletions(-) > > [...] > > > static void rtl8812ae_get_delta_swing_table(struct ieee80211_hw *hw, > - u8 **up_a, u8 **down_a, > - u8 **up_b, u8 **down_b) > + const u8 **up_a, > + const u8 **down_a, > + const u8 **up_b, > + const u8 **down_b) > { > struct rtl_priv *rtlpriv = rtl_priv(hw); > struct rtl_phy *rtlphy = &rtlpriv->phy; >
Please remove below type casting:
@@ -1872,10 +1872,10 @@ static void rtl8821ae_get_delta_swing_table(struct ieee80211_hw *hw, *up_b = rtl8821ae_delta_swing_table_idx_5gb_p[2]; *down_b = rtl8821ae_delta_swing_table_idx_5gb_n[2]; } else { - *up_a = (u8 *)rtl8818e_delta_swing_table_idx_24gb_p; - *down_a = (u8 *)rtl8818e_delta_swing_table_idx_24gb_n; - *up_b = (u8 *)rtl8818e_delta_swing_table_idx_24gb_p; - *down_b = (u8 *)rtl8818e_delta_swing_table_idx_24gb_n; + *up_a = rtl8818e_delta_swing_table_idx_24gb_p; + *down_a = rtl8818e_delta_swing_table_idx_24gb_n; + *up_b = rtl8818e_delta_swing_table_idx_24gb_p; + *down_b = rtl8818e_delta_swing_table_idx_24gb_n; } return; }
[...] | |