Messages in this thread | | | Date | 29 Jun 2020 09:38:09 +0900 | From | Kuninori Morimoto <> | Subject | Re: [PATCH v4 08/23] ASoC: soc-core: Fix component name_prefix parsing |
| |
Hi Sameer
Thank you for your patch
# I guess there was ML registering magic until v3 ? # This is 1st time for me to get this patch series...
> The "prefix" can be defined in DAI link node or it can be specified as > part of the component node itself. Currently "sound-name-prefix" defined > in a component is not taking effect. Actually the property is not getting > parsed. It can be fixed by parsing "sound-name-prefix" property whenever > "prefix" is missing in DAI link Codec node. > > Signed-off-by: Sameer Pujar <spujar@nvidia.com> (snip) > @@ -1111,8 +1111,10 @@ static void soc_set_name_prefix(struct snd_soc_card *card, > struct snd_soc_codec_conf *map = &card->codec_conf[i]; > > if (snd_soc_is_matching_component(&map->dlc, component)) { > - component->name_prefix = map->name_prefix; > - return; > + if (map->name_prefix) { > + component->name_prefix = map->name_prefix; > + return; > + } > } > }
This is nit-pick but it can be like this ?
if (snd_soc_is_matching_component(&map->dlc, component) && map->name_prefix) { ... }
Thank you for your help !!
Best regards --- Kuninori Morimoto
| |