lkml.org 
[lkml]   [2020]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/10] perf tools: Add struct expr_parse_data to keep expr value
    On Fri, Jun 26, 2020 at 01:04:41PM -0700, Ian Rogers wrote:
    > On Fri, Jun 26, 2020 at 12:47 PM Jiri Olsa <jolsa@kernel.org> wrote:
    > >
    > > Adding struct expr_parse_data to keep expr value
    > > instead of just simple double pointer, so we can
    > > store more data for ID in following changes.
    >
    > Nit, expr_parse_data sounds a bit like data that is created just at
    > parse time. Perhaps id_data, for data associated with an id?

    we should keep the expr prefix, expr_id_data ?

    jirka

    \
     
     \ /
      Last update: 2020-06-28 23:26    [W:3.710 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site