Messages in this thread | | | Subject | Re: [f2fs-dev] [PATCH] f2fs: remove unnecessary judgments in __insert_free_nid() | From | Chao Yu <> | Date | Sun, 28 Jun 2020 10:56:18 +0800 |
| |
On 2020/6/26 22:39, Liu Song via Linux-f2fs-devel wrote: > From: Liu Song <liu.song11@zte.com.cn> > > The value of state must be equal to FREE_NID, so the if > condition judgment can be removed. > > Signed-off-by: Liu Song <liu.song11@zte.com.cn> > --- > fs/f2fs/node.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index 03e24df1c84f..0adeb20f19c9 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -2118,8 +2118,7 @@ static int __insert_free_nid(struct f2fs_sb_info *sbi, > > f2fs_bug_on(sbi, state != i->state); > nm_i->nid_cnt[state]++; > - if (state == FREE_NID) > - list_add_tail(&i->list, &nm_i->free_nid_list); > + list_add_tail(&i->list, &nm_i->free_nid_list);
In previous design, @state allow accepting both FREE_NID and PREALLOC_NID, If you remove that condition, it's not correct to add free nid entry into free_nid_list when passing PREALLOC_NID in @state, now, we only pass @state with FREE_NID, so it's better to remove that parameter directly.
Thanks,
> return 0; > } > >
| |