Messages in this thread | | | From | "Alim Akhtar" <> | Subject | RE: [PATCH] scsi: ufs: ufs-exynos: Remove an unnecessary NULL check | Date | Sun, 28 Jun 2020 07:26:29 +0530 |
| |
Hi Dan,
> -----Original Message----- > From: Dan Carpenter <dan.carpenter@oracle.com> > On Sat, Jun 27, 2020 at 10:51:44PM +0530, Alim Akhtar wrote: > > Hi Dan > > > > > -----Original Message----- > > > The "head" pointer can't be NULL because it points to an address in the > > middle > > > of a ufs_hba struct. Looking at this code, probably someone would wonder > > if > > > the intent was to check whether "hba" is NULL, but "hba" > > > isn't NULL and the check can just be removed. > > > > > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > > --- > > Please add Fixes: tag > > With that > > Acked-by: Alim Akhtar <alim.akhtar@samsung.com> > > It's not a bug fix it's just a cleanup. > Acked-by: Alim Akhtar <alim.akhtar@samsung.com>
Thanks!
> regards, > dan carpenter
| |