lkml.org 
[lkml]   [2020]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fbtft-bus.c: Removing that prohibited space before ')'
Hi K,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v5.8-rc2 next-20200626]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/B-K-Karthik/fbtft-bus-c-Removing-that-prohibited-space-before/20200627-125315
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 92cd1b5d65f5c67147c7da39a3c2ad7e6ff81027
config: x86_64-randconfig-r015-20200628 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project a43b99a1e38e2beffb68a6db93f216f511e7fd41)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/staging/fbtft/fbtft-bus.c:65:53: error: too few arguments provided to function-like macro invocation
define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
^
drivers/staging/fbtft/fbtft-bus.c:14:9: note: macro 'define_fbtft_write_reg' defined here
#define define_fbtft_write_reg(func, buffer_type, data_type, modifier) \
^
>> drivers/staging/fbtft/fbtft-bus.c:65:1: error: unknown type name 'define_fbtft_write_reg'
define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
^
drivers/staging/fbtft/fbtft-bus.c:67:57: error: too few arguments provided to function-like macro invocation
define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
^
drivers/staging/fbtft/fbtft-bus.c:14:9: note: macro 'define_fbtft_write_reg' defined here
#define define_fbtft_write_reg(func, buffer_type, data_type, modifier) \
^
drivers/staging/fbtft/fbtft-bus.c:67:1: error: unknown type name 'define_fbtft_write_reg'
define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
^
>> drivers/staging/fbtft/fbtft-bus.c:86:3: error: non-void function 'fbtft_write_reg8_bus9' should return a value [-Wreturn-type]
return;
^
drivers/staging/fbtft/fbtft-bus.c:109:3: error: non-void function 'fbtft_write_reg8_bus9' should return a value [-Wreturn-type]
return;
^
6 errors generated.

vim +65 drivers/staging/fbtft/fbtft-bus.c

64
> 65 define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
66 define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
> 67 define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
68
69 void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
70 {
71 va_list args;
72 int i, ret;
73 int pad = 0;
74 u16 *buf = (u16 *)par->buf;
75
76 if (unlikely(par->debug & DEBUG_WRITE_REGISTER)) {
77 va_start(args, len);
78 for (i = 0; i < len; i++)
79 *(((u8 *)buf) + i) = (u8)va_arg(args, unsigned int);
80 va_end(args);
81 fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par,
82 par->info->device, u8, buf, len, "%s: ",
83 __func__);
84 }
85 if (len <= 0)
> 86 return;
87
88 if (par->spi && (par->spi->bits_per_word == 8)) {
89 /* we're emulating 9-bit, pad start of buffer with no-ops
90 * (assuming here that zero is a no-op)
91 */
92 pad = (len % 4) ? 4 - (len % 4) : 0;
93 for (i = 0; i < pad; i++)
94 *buf++ = 0x000;
95 }
96
97 va_start(args, len);
98 *buf++ = (u8)va_arg(args, unsigned int);
99 i = len - 1;
100 while (i--) {
101 *buf = (u8)va_arg(args, unsigned int);
102 *buf++ |= 0x100; /* dc=1 */
103 }
104 va_end(args);
105 ret = par->fbtftops.write(par, par->buf, (len + pad) * sizeof(u16));
106 if (ret < 0) {
107 dev_err(par->info->device,
108 "write() failed and returned %d\n", ret);
109 return;
110 }
111 }
112 EXPORT_SYMBOL(fbtft_write_reg8_bus9);
113

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2020-06-28 02:20    [W:0.161 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site