lkml.org 
[lkml]   [2020]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/2] dt-bindings: iio: bmc150_magn: Document and fix missing compatibles
    On Mon, 22 Jun 2020 08:01:09 +0200
    Krzysztof Kozlowski <krzk@kernel.org> wrote:

    > The driver supports also BMC156B and BMM150B but these compatibles had
    > redundant suffix "_magn". Add existing compatibles marking them
    > deprecated along with adding a new, proper one for this family of
    > devices.
    Thanks for tidying this up.

    The BMC156B is a dual magnetometer and accelerometer chip
    so for that one the _magn postfix probably is needed.

    Or am I missing something?

    The way this does SPI is rather odd but seems to be the same as the bmc150
    (two chips with non overlapping register maps).

    Jonathan

    >
    > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    >
    > ---
    >
    > Changes since v1:
    > 1. Mark old compatibles as deprecated, add new one.
    > ---
    > .../devicetree/bindings/iio/magnetometer/bmc150_magn.txt | 6 +++++-
    > 1 file changed, 5 insertions(+), 1 deletion(-)
    >
    > diff --git a/Documentation/devicetree/bindings/iio/magnetometer/bmc150_magn.txt b/Documentation/devicetree/bindings/iio/magnetometer/bmc150_magn.txt
    > index fd5fca90fb39..efeda055be6a 100644
    > --- a/Documentation/devicetree/bindings/iio/magnetometer/bmc150_magn.txt
    > +++ b/Documentation/devicetree/bindings/iio/magnetometer/bmc150_magn.txt
    > @@ -4,7 +4,11 @@ http://ae-bst.resource.bosch.com/media/products/dokumente/bmc150/BST-BMC150-DS00
    >
    > Required properties:
    >
    > - - compatible : should be "bosch,bmc150_magn"
    > + - compatible : should be one of:
    > + "bosch,bmc150_magn"
    > + "bosch,bmc156"
    > + "bosch,bmc156_magn" (DEPRECATED, use bosch,bmc156)
    > + "bosch,bmm150_magn" (DEPRECATED, use bosch,bmc156)
    > - reg : the I2C address of the magnetometer
    >
    > Optional properties:

    \
     
     \ /
      Last update: 2020-06-27 15:45    [W:5.305 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site