Messages in this thread | | | Date | Fri, 26 Jun 2020 13:18:56 -0700 | From | Kees Cook <> | Subject | Re: [PATCH 1/2] kbuild: remove cc-option test of -fno-stack-protector |
| |
On Sat, Jun 27, 2020 at 03:59:12AM +0900, Masahiro Yamada wrote: > Some Makefiles already pass -fno-stack-protector unconditionally. > For example, arch/arm64/kernel/vdso/Makefile, arch/x86/xen/Makefile. > No problem report so far about hard-coding this option. So, we can > assume all supported compilers know -fno-stack-protector. > > GCC 4.8 and Clang support this option (https://godbolt.org/z/_HDGzN) > > Get rid of cc-option from -fno-stack-protector. > > Remove CONFIG_CC_HAS_STACKPROTECTOR_NONE, which should always be 'y'. > > Note: > arch/mips/vdso/Makefile adds -fno-stack-protector twice, first > unconditionally, and second conditionally. I removed the second one. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |