Messages in this thread | | | Subject | Re: [PATCH 5/6] net: phy: reset the PHY even if probe() is not implemented | From | Florian Fainelli <> | Date | Fri, 26 Jun 2020 09:06:25 -0700 |
| |
On 6/26/2020 8:53 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > Currently we only call phy_device_reset() if the PHY driver implements > the probe() callback. This is not mandatory and many drivers (e.g. > realtek) don't need probe() for most devices but still can have reset > GPIOs defined. There's no reason to depend on the presence of probe() > here so pull the reset code out of the if clause. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
OK we can always add support for letting PHY drivers manage their own reset line(s) during probe in a later changeset.
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |