lkml.org 
[lkml]   [2020]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [TEGRA194_CPUFREQ PATCH v4 1/4] dt-bindings: arm: Add t194 ccplex compatible and bpmp property
    On Fri, Jun 26, 2020 at 09:13:53PM +0530, Sumit Gupta wrote:
    > To do frequency scaling on all CPUs within T194 CPU Complex, we need
    > to query BPMP for data on valid operating points. Document a compatible
    > string under 'cpus' node to represent the CPU Complex for binding drivers
    > like cpufreq which don't have their node or CPU Complex node to bind to.
    > Also, document a property to point to the BPMP device that can be queried
    > for all CPUs.
    >
    > Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
    > ---
    > Documentation/devicetree/bindings/arm/cpus.yaml | 9 +++++++++
    > 1 file changed, 9 insertions(+)
    >
    > diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml
    > index a018147..737b55e 100644
    > --- a/Documentation/devicetree/bindings/arm/cpus.yaml
    > +++ b/Documentation/devicetree/bindings/arm/cpus.yaml
    > @@ -162,6 +162,7 @@ properties:
    > - nvidia,tegra132-denver
    > - nvidia,tegra186-denver
    > - nvidia,tegra194-carmel
    > + - nvidia,tegra194-ccplex
    > - qcom,krait
    > - qcom,kryo
    > - qcom,kryo260
    > @@ -255,6 +256,14 @@ properties:
    >
    > where voltage is in V, frequency is in MHz.
    >
    > + nvidia,bpmp:
    > + $ref: '/schemas/types.yaml#/definitions/phandle'
    > + descrption: |
    > + Specifies the bpmp node that needs to be queried to get
    > + operating point data for all CPUs.
    > +
    > + Optional for NVIDIA Tegra194 Carmel CPUs

    Hi,

    The code (next patches) suggests, that the property is relevant for Tegra194
    only. If it is required for compatible=tegra194-ccplex, then maybe you can
    mark it so (there is already similar constraint described in the file, just
    before the example section).

    Best Regards,
    Michał Mirosław

    \
     
     \ /
      Last update: 2020-06-26 18:04    [W:3.208 / U:0.812 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site