lkml.org 
[lkml]   [2020]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 05/10] misc: lkdtm: Always provide prototype for lkdtm_DOUBLE_FAULT()
    On Fri, Jun 26, 2020 at 02:05:20PM +0100, Lee Jones wrote:
    > lkdtm_DOUBLE_FAULT() already has internal logic to handle
    > !CONFIG_X86_32. Compiling out the prototype actually prevents
    > that logic from being useful.
    >
    > Fixes the following W=1 warning:
    >
    > drivers/misc/lkdtm/bugs.c: At top level:
    > drivers/misc/lkdtm/bugs.c:420:6: warning: no previous prototype for ‘lkdtm_DOUBLE_FAULT’ [-Wmissing-prototypes]
    > 420 | void lkdtm_DOUBLE_FAULT(void)
    > | ^~~~~~~~~~~~~~~~~~
    >
    > Cc: Kees Cook <keescook@chromium.org>
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>

    Thanks! This change is actually already part of another
    patch and is waiting for Greg to pick up:
    https://lore.kernel.org/lkml/20200529200347.2464284-5-keescook@chromium.org/

    --
    Kees Cook

    \
     
     \ /
      Last update: 2020-06-26 17:24    [W:2.705 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site