lkml.org 
[lkml]   [2020]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] pci: Add pci device even if the driver failed to attach
    On Thu, Jun 25, 2020 at 05:27:09PM -0700, Rajat Jain wrote:
    > device_attach() returning failure indicates a driver error
    > while trying to probe the device. In such a scenario, the PCI
    > device should still be added in the system and be visible to
    > the user.
    >
    > This patch partially reverts:
    > commit ab1a187bba5c ("PCI: Check device_attach() return value always")
    >
    > Signed-off-by: Rajat Jain <rajatja@google.com>
    > ---
    > drivers/pci/bus.c | 6 +-----
    > 1 file changed, 1 insertion(+), 5 deletions(-)
    >
    > diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c
    > index 8e40b3e6da77d..3cef835b375fd 100644
    > --- a/drivers/pci/bus.c
    > +++ b/drivers/pci/bus.c
    > @@ -322,12 +322,8 @@ void pci_bus_add_device(struct pci_dev *dev)
    >
    > dev->match_driver = true;
    > retval = device_attach(&dev->dev);
    > - if (retval < 0 && retval != -EPROBE_DEFER) {
    > + if (retval < 0 && retval != -EPROBE_DEFER)
    > pci_warn(dev, "device attach failed (%d)\n", retval);
    > - pci_proc_detach_device(dev);
    > - pci_remove_sysfs_dev_files(dev);
    > - return;
    > - }

    Nice catch, sysfs stuff shouldn't be dependant if a driver is bound to a
    device or not.

    Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    \
     
     \ /
      Last update: 2020-06-26 16:15    [W:2.739 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site