lkml.org 
[lkml]   [2020]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [patch 10/32] linux/bits.h: fix unsigned less than zero warnings
On Fri, Jun 26, 2020 at 3:24 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Fri, Jun 26, 2020 at 2:37 PM Rikard Falkeborn
> <rikard.falkeborn@gmail.com> wrote:
> > Den fre 26 juni 2020 08:32Linus Torvalds <torvalds@linux-foundation.org> skrev:
>
> ...
>
> > I'll just say no and point to this email next time someone complains instead.
>
> "No" is not constructive here. People can be annoyed with warning
> messages, but the real issue here are the various CI systems which
> send a lot of spam because of that. As a maintainer I would need to
> drop CI in order to see a good patch. If Linus considers that warning
> useless, then probably you can change your patch to do what he
> proposed.

How about moving that warning from W=1 to W=2? Generally speaking
I'd expect W=1 warnings to be in a category of "it's generally better to
address this in the code, but we can't turn it on by default because the
output gets too noisy", as opposed to W=2 meaning "this sometimes
finds a real problem, but fixing the warning often makes code worse."

Arnd

\
 
 \ /
  Last update: 2020-06-26 16:05    [W:0.123 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site